-
Notifications
You must be signed in to change notification settings - Fork 47.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove passing rootNode
to lifecycle methods
#416
Comments
+1. Also makes it more annoying to add new useful arguments if there ever are any. |
Ops, added. |
Bump, this is about to bite us with the next github sync since we added a param to |
We still need to document it :) |
I'm actually doing it that's why! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Referring to #276:
I think we should remove the
rootNode
being passed tocomponentDidMount
andcomponentDidUpdate
. For two reasons:componentWillUnmount
. Since we're not addingrootNode
to it due to reason 1, the only way to stay consistent is to remove it for the other two methods.The text was updated successfully, but these errors were encountered: