Skip to content

Commit 96ad60e

Browse files
cortinicoLuna Wei
authored and
Luna Wei
committed
Do not remove libjscexecutor.so from release builds (#32932)
Summary: Pull Request resolved: #32932 As the title says, we dont' want to remove `libjscexecutor.so` when baking release builds and having JSC enable as this leads to instacrashes. Fixes #32928 Fixes #32927 Changelog: [Android] [Fixed] - Do not remove libjscexecutor.so from release builds Reviewed By: ShikaSD Differential Revision: D33681932 fbshipit-source-id: 5b59fd1fb76c80c191198d65c916bbbd9232c75b
1 parent 218b4c1 commit 96ad60e

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/TaskConfiguration.kt

-4
Original file line numberDiff line numberDiff line change
@@ -244,10 +244,6 @@ private fun Project.cleanupVMFiles(
244244
} else {
245245
// For JSC, delete all the libhermes* files
246246
it.include("**/libhermes*.so")
247-
// Delete the libjscexecutor from release build
248-
if (cleanup) {
249-
it.include("**/libjscexecutor.so")
250-
}
251247
}
252248
}
253249
.visit { visit ->

react.gradle

-4
Original file line numberDiff line numberDiff line change
@@ -363,10 +363,6 @@ afterEvaluate {
363363
} else {
364364
// For JSC, delete all the libhermes* files
365365
include "**/libhermes*.so"
366-
// Delete the libjscexecutor from release build
367-
if (cleanup) {
368-
include "**/libjscexecutor.so"
369-
}
370366
}
371367
}.visit { details ->
372368
def targetVariant1 = ".*/transforms/[^/]*/${targetPath}/.*"

0 commit comments

Comments
 (0)