Remove getAsyncTransport sink API

Summary: As in title Differential Revision: D53110708 fbshipit-source-id: fd08c7809c5153424587dc3fae97651508a06767
facebook · Jan 27, 2024 · 020db5b · 020db5b
1 parent 4995027
commit 020db5b
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 5 deletions.
diff --git a/proxygen/lib/http/sink/HTTPSink.h b/proxygen/lib/http/sink/HTTPSink.h
@@ -44,10 +44,11 @@ class HTTPSink {
   [[nodiscard]] virtual CodecProtocol getCodecProtocol() const = 0;
   [[nodiscard]] virtual const folly::SocketAddress& getLocalAddress() const = 0;
   [[nodiscard]] virtual const folly::SocketAddress& getPeerAddress() const = 0;
+  [[nodiscard]] virtual const folly::AsyncTransportCertificate*
+  getPeerCertificate() const = 0;
   [[nodiscard]] virtual folly::Optional<HTTPPriority> getHTTPPriority()
       const = 0;
-  [[nodiscard]] virtual const folly::AsyncTransport* getTCPTransport()
-      const = 0;
+  [[nodiscard]] virtual int getTCPTransportFD() const = 0;
   [[nodiscard]] virtual quic::QuicSocket* getQUICTransport() const = 0;
   [[nodiscard]] virtual std::chrono::seconds getSessionIdleDuration() const = 0;
   virtual void getCurrentFlowControlInfo(FlowControlInfo*) const = 0;

diff --git a/proxygen/lib/http/sink/HTTPTransactionSink.cpp b/proxygen/lib/http/sink/HTTPTransactionSink.cpp
@@ -13,6 +13,27 @@
 
 namespace proxygen {
 
+int HTTPTransactionSink::getTCPTransportFD() const {
+  auto transport = httpTransaction_->getTransport().getUnderlyingTransport();
+  const folly::AsyncSocket* sock = nullptr;
+  if (transport) {
+    sock = transport->getUnderlyingTransport<folly::AsyncSocket>();
+  }
+  if (sock) {
+    return sock->getNetworkSocket().toFd();
+  }
+  return -1;
+}
+
+const folly::AsyncTransportCertificate*
+HTTPTransactionSink::getPeerCertificate() const {
+  auto transport = httpTransaction_->getTransport().getUnderlyingTransport();
+  if (transport) {
+    return transport->getPeerCertificate();
+  }
+  return nullptr;
+}
+
 quic::QuicSocket* HTTPTransactionSink::getQUICTransport() const {
   auto session = httpTransaction_->getTransport().getHTTPSessionBase();
   if (auto hqSession = dynamic_cast<HQSession*>(session)) {

diff --git a/proxygen/lib/http/sink/HTTPTransactionSink.h b/proxygen/lib/http/sink/HTTPTransactionSink.h
@@ -49,9 +49,9 @@ class HTTPTransactionSink : public HTTPSink {
   [[nodiscard]] const folly::SocketAddress& getPeerAddress() const override {
     return httpTransaction_->getPeerAddress();
   }
-  [[nodiscard]] const folly::AsyncTransport* getTCPTransport() const override {
-    return httpTransaction_->getTransport().getUnderlyingTransport();
-  }
+  [[nodiscard]] const folly::AsyncTransportCertificate* getPeerCertificate()
+      const override;
+  [[nodiscard]] int getTCPTransportFD() const override;
   [[nodiscard]] quic::QuicSocket* getQUICTransport() const override;
   [[nodiscard]] std::chrono::seconds getSessionIdleDuration() const override {
     return sessionIdleDuration_;