Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that Docker is optional? #1110

Closed
ablakey opened this issue Nov 13, 2018 · 3 comments · Fixed by #1848
Closed

Document that Docker is optional? #1110

ablakey opened this issue Nov 13, 2018 · 3 comments · Fixed by #1848
Labels
documentation The issue is related to the documentation of Docusaurus

Comments

@ablakey
Copy link

ablakey commented Nov 13, 2018

📚 Documentation

Following the Getting Started documentation led me to a pretty great starting point for building my own documentation site. However it didn't mention that I would be getting a bunch of Docker-related files. These are great, but not always useful. Would it be a good idea to report somewhere that these files will exist and that they're optional and can be cleaned up if unwanted?

I'm happy to take a crack at writing it if this is a fair assessment.

Have you read the Contributing Guidelines on issues?

Sure have, coach!
@endiliey endiliey added the documentation The issue is related to the documentation of Docusaurus label Nov 21, 2018
@yangshun
Copy link
Contributor

@ablakey Yes that's reasonable. Feel free to submit a PR for this!

@ablakey
Copy link
Author

ablakey commented Feb 15, 2019

Great. Glad to see I understand the situation. I'll tackle this next time I'm working on docs.

@EricPonvelle
Copy link
Contributor

I created this pull request to clarify the text - #1848

@EricPonvelle EricPonvelle mentioned this issue Oct 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation The issue is related to the documentation of Docusaurus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: document docker is optional
4 participants
@yangshun @ablakey @EricPonvelle @endiliey