fix(fabric.Text) fix typo in cacheProperties preventing cache clear to work #6775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes
…On Tue, 5 Jan 2021 at 10:44, Mathias E. ***@***.***> wrote:
Hello,
i have an issue, when changing the font family, the textbox doesnt update,
this issue can explain why ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6775 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJDQQG2MQSITMYIC6EXIA3SYLNRNANCNFSM4VRIKC5A>
.
|
|
Thanks ! i deleted my comment, since the answer was in the issue you linked |
shanicerae
pushed a commit
to shanicerae/fabric.js
that referenced
this pull request
Jan 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactoring some code i missed a couple of brakets around a multiline string.
This wasn't caught by any test, now we have a test to catch it.
close #6767