Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: 'scaling' event triggered before object position is adjusted #6649

Closed
SLKnutson opened this issue Oct 14, 2020 · 6 comments
Closed

v4: 'scaling' event triggered before object position is adjusted #6649

SLKnutson opened this issue Oct 14, 2020 · 6 comments
Labels

Comments

@SLKnutson
Copy link
Contributor

Version

4.2.0

Expected Behavior

The 'scaling' event should be fired after the object position is adjusted to pin to a specific side/corner. That is how fabric behaved pre-v4, and in my opinion, what most people would expect.

Actual Behavior

The 'scaling' event is triggered after the scale is changed but before the position is adjusted to pin to a specific side/corner.

Thanks!

@asturur
Copy link
Member

asturur commented Oct 14, 2020

i think you are rigth. this is changed and messy right now.

I m not sure how to fix it at this point.

Probably also half people prefer the old position, half the new. But i agree should be fixed.

@SLKnutson
Copy link
Contributor Author

I'm also running into this issue with rotation. I think skewing also has this issue. I'll take a stab at fixing it.

@stale
Copy link

stale bot commented Oct 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Oct 29, 2020
@asturur asturur added bug and removed stale Issue marked as stale by the stale bot labels Nov 1, 2020
@Eltonfjunior
Copy link

Good afternoon.
I am also having the same problem, do you already have any return on this demand?

@asturur
Copy link
Member

asturur commented Nov 3, 2020

We have a PR, that is fine, but we need to avoid breaking the interface and i did not have a time to sit down and see what is the solution.

#6650

@ShaMan123
Copy link
Contributor

closed by #6650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants