issue with setSrc for crossorigin images

[dkirchhof]

Hello,
i have some trouble with changing the src of an image.

As you can see in the fiddle, i want to change the src of an image via the setSrc function.
After calling canvas.renderAll in the setSrc-callback nothing happens.
The image will be loaded twice (you can see it in the network panel of the chrome devtools). So the callback will be triggered after the first load, but the image will be rendered correctly after the image is loaded the second time. Also all image options like width and height will be reseted.

This problem occurs only if i set the crossOrigin option (to anonymous).

http://jsfiddle.net/v6e0hd5o/1/

Tested with fabricjs v. 4.0.0-beta.12 on chrome 83.

[melchiar]

Don't forget to set crossOrigin: "anonymous" when calling setSrc() as well

http://jsfiddle.net/melchiar/jrnwu2tL/

[asturur]

There is some code in fabricJS that chrome 83 made broken.
The broken part makes sense, since fabricJS during setSRC will try to set the crossOrigin of the element to the one of the fabric.Image ( from the previous element ).
This is wrong, because the new element from setSrc will be loaded with the crossOrigin specified in the options and if different from the previous one will be changed again, invalidating the image completely.

It is effectively a bug, i m just not sure how should be fixed.

optionA:
you do setSrc and the fabric.Object gets the new crossOrigin specified in setSrc

option B:
you do setSrc and the image is loaded with the current crossOrigin

I really do not know what makes more sense.

[melchiar]

Just my 2 cents... it seems to me that optionA is the most consistent. It makes sense that crossOrigin would be specified every time a new image is loaded, whether you're creating a new image object or changing the source of an existing image object. After all, the new url when calling setSrc() might be a local file and not need the property, yes?

[asturur]

Yes. Also to me asking to specify crossOrigin every load just bring attention to the fact that today you have to deal with it.