Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity ColorMatrix when used with other filters breaks filter behaviour #5118

Closed
brandondong opened this issue Jul 23, 2018 · 1 comment · Fixed by #5129
Closed

Identity ColorMatrix when used with other filters breaks filter behaviour #5118

brandondong opened this issue Jul 23, 2018 · 1 comment · Fixed by #5129
Labels

Comments

@brandondong
Copy link
Contributor

Version

2.3.3

Test Case

https://jsfiddle.net/ojt42731/14/

Steps to reproduce

Press the Apply Filter button.

Expected Behavior

Sepia filter applied to image.

Actual Behavior

Image disappears.

I believe the isNeutralState optimizations may be causing this issue. If I change the values of the matrix slightly, the test case works as expected. In my real application use case, I was generating a colour matrix dynamically based on parameter values. It just so happened to land on the identity matrix causing this issue.

@asturur
Copy link
Member

asturur commented Jul 24, 2018

I see this is getting me headache, i guess i should remove the filters before getting them in the filter chain rather than in the middle of filtering, i have not time to setup a proper debug test with webgl, but looks like that removing the first filter causes the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants