Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubTargets in custom group is empty #4752

Closed
blucobalto opened this issue Feb 21, 2018 · 1 comment · Fixed by #4753
Closed

SubTargets in custom group is empty #4752

blucobalto opened this issue Feb 21, 2018 · 1 comment · Fixed by #4753

Comments

@blucobalto
Copy link
Contributor

Hi,
I created a custom group.

var fabric.CustomGroup = fabric.util.createClass(fabric.Group, { type : 'CustomGroup', ... });

I added several items to the group (line, circle, group, rect ...).

I set subTargetCheck = true.

Problem:
when I click on the object (CustomGroup) subTargets is always empty.

In fabric.js (version: '2.0.2' line: 10109) I read the following code:

if (target.type === 'group' && target.subTargetCheck) {...
But target.type is equal to "CustomGroup".

Please, how can I solve this problem?
Thanks a lot,
Blu

@asturur
Copy link
Member

asturur commented Feb 21, 2018

That line must be changed in target instanceof fabric.Group

After have verified that it works on ie10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants