Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add domain datasource #34

Merged
merged 9 commits into from
Dec 23, 2019
Merged

add domain datasource #34

merged 9 commits into from
Dec 23, 2019

Conversation

illi-j
Copy link
Contributor

@illi-j illi-j commented Dec 17, 2019

This PR add domain datasource.

falzm
falzm suggested changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@falzm falzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes requested, but good work @illi-j: welcome to the very select Terraform provider developers club 😉

@falzm falzm mentioned this pull request Dec 19, 2019
Merged
pierre-emmanuelJ
pierre-emmanuelJ requested changes Dec 23, 2019
View reviewed changes
@illi-j illi-j requested a review from falzm December 23, 2019 09:19
falzm
falzm approved these changes Dec 23, 2019
View reviewed changes
Copy link
Contributor

@falzm falzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

pierre-emmanuelJ
pierre-emmanuelJ approved these changes Dec 23, 2019
View reviewed changes
Copy link
Member

@pierre-emmanuelJ pierre-emmanuelJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎁 📀

@falzm falzm merged commit e6dad41 into exoscale:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falzm falzm falzm approved these changes

@pierre-emmanuelJ pierre-emmanuelJ pierre-emmanuelJ approved these changes

@jessicatoscani jessicatoscani jessicatoscani approved these changes

Assignees
No one assigned
Labels
documentation new-data-source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@illi-j @falzm @pierre-emmanuelJ @jessicatoscani