Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add datasource on IP Address #31

Merged
merged 14 commits into from
Dec 24, 2019
Merged

Add datasource on IP Address #31

merged 14 commits into from
Dec 24, 2019

Conversation

pierre-emmanuelJ
Copy link
Member

@pierre-emmanuelJ pierre-emmanuelJ commented Dec 11, 2019 •
edited
Loading

This PR add datasource on Exoscale IPAddress resource

@ghost ghost added size/M and removed size/M labels Dec 11, 2019
@pierre-emmanuelJ
Copy link
Member Author

Acceptance test OK!

TF_ACC=1  EXOSCALE_COMPUTE_ENDPOINT="https://api.exoscale.ch/compute"  EXOSCALE_API_KEY=EXOXX EXOSCALE_API_SECRET=XXXXX  go test -mod vendor -v -timeout 60m github.com/terraform-providers/terraform-provider-exoscale/exoscale -run '^(TestAccDatasourceComputeIPAddress)$'
=== RUN   TestAccDatasourceComputeIPAddress
--- PASS: TestAccDatasourceComputeIPAddress (9.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-exoscale/exoscale	9.020s

@pierre-emmanuelJ
Copy link
Member Author

⚠️ WIP ⚠️

@pierre-emmanuelJ
Copy link
Member Author

Missing tag implementation

@falzm falzm added the 🚧 WIP Work In Progress label Dec 12, 2019
@pierre-emmanuelJ
Copy link
Member Author

Adding tags implementation!

=== RUN   TestAccDatasourceComputeIPAddress
--- PASS: TestAccDatasourceComputeIPAddress (9.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-exoscale/exoscale	9.534s

@falzm falzm removed the 🚧 WIP Work In Progress label Dec 16, 2019
@pierre-emmanuelJ
Copy link
Member Author

pierre-emmanuelJ commented Dec 16, 2019 •
edited
Loading

Some executable for testing:

Linux: https://ppsos-ch-dk-2.exo.io/cloud/public/TF/linux/terraform-provider-exoscale_v0.15.0
md5: 6a590544dcac88a90bd3fbd0bdf2486b

MacOS: https://ppsos-ch-dk-2.exo.io/cloud/public/TF/darwin/terraform-provider-exoscale_v0.15.0
md5: 68a579d2aad394863b87fed5e309b083

@ghost ghost added size/XL documentation and removed size/L labels Dec 17, 2019
falzm
falzm suggested changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@falzm falzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work @pierre-emmanuelJ, see my comments inline.

@ghost ghost added size/L and removed size/XL labels Dec 23, 2019
@pierre-emmanuelJ
Implem datasource IP Address without tag
80cd3e7 
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
@pierre-emmanuelJ
Add test
cac2bfd 
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
@pierre-emmanuelJ
fixup! Add test
62759ed 
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
@pierre-emmanuelJ
Fix test
eead6b7 
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
@pierre-emmanuelJ
Fiy test
f3b52a6 
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
@pierre-emmanuelJ
Add tags implem with test
9eafb69 
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
@pierre-emmanuelJ
Fix test and tags
3f8d85e 
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
@pierre-emmanuelJ
Add doc
c7aca25 
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
@pierre-emmanuelJ
fixup! Add doc
ef5aed8 
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
@pierre-emmanuelJ
Fix review
60ed641 
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
@pierre-emmanuelJ pierre-emmanuelJ force-pushed the pej/ch6128/terraform-provider-data-source-exoscale-ipaddress branch from 48770c7 to 60ed641 Compare December 23, 2019 14:12
@pierre-emmanuelJ
fixup! Fix review
e061040 
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
@pierre-emmanuelJ
Add some var in acc test
e8839e3 
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
@ghost ghost added size/XL and removed size/L labels Dec 23, 2019
falzm
falzm approved these changes Dec 23, 2019
View reviewed changes
Copy link
Contributor

@falzm falzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pierre-emmanuelJ
Merge branch 'master' into pej/ch6128/terraform-provider-data-source-…
da4d01f 
…exoscale-ipaddress
@pierre-emmanuelJ
typo
2400de6 
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
illi-j
illi-j approved these changes Dec 24, 2019
View reviewed changes
Copy link
Contributor

@illi-j illi-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👟

@falzm falzm merged commit d85af59 into exoscale:master Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falzm falzm falzm approved these changes

@illi-j illi-j illi-j approved these changes

@jessicatoscani jessicatoscani jessicatoscani approved these changes

Assignees
No one assigned
Labels
documentation new-data-source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pierre-emmanuelJ @falzm @illi-j @jessicatoscani