Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Running state if state is Migrating in compute #17

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Set Running state if state is Migrating in compute #17

merged 2 commits into from
Oct 29, 2019

Conversation

pierre-emmanuelJ
Copy link
Member

Dont try to converge state for migrating instances

...
]
        size               = "Medium"
      ~ state              = "Migrating" -> "Running"
        tags               = {
...

@pierre-emmanuelJ
Add running state if state is Migrating in compute
b7b3dc2 
Signed-off-by: Pierre-Emmanuel Jacquier <pierre-emmanuel.jacquier@exoscale.ch>
@ghost ghost added the size/XS label Oct 29, 2019
@pierre-emmanuelJ pierre-emmanuelJ changed the title Add running state if state is Migrating in compute Set Running state if state is Migrating in compute Oct 29, 2019
@pierre-emmanuelJ
Add comment
7d892a4 
Signed-off-by: Pierre-Emmanuel Jacquier <pierre-emmanuel.jacquier@exoscale.ch>
falzm
falzm approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@falzm falzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pierre-emmanuelJ

@falzm falzm merged commit c8c7f3e into exoscale:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falzm falzm falzm approved these changes

@mcorbin mcorbin mcorbin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierre-emmanuelJ @falzm @mcorbin