-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the 'Beer Song' exercise #203
Adds the 'Beer Song' exercise #203
Conversation
@Zureka Can you add a I'll look over this in a couple of hours. |
@Zureka The config entry you posted above looks good, just place it after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, after the changes be sure to run the bin/presubmit.dart file to ensure everything is correct and formatted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good, just a couple minor tweaks and I'll be ready to approve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zureka, would you feel comfortable squashing the three commits into one? Otherwise, I approve
9cfb016
to
0e58846
Compare
@Stargator I just force pushed the squashed commits. Thanks for the thorough review! I would be willing to add more exercises after this one. I'll take a look at the exercises mentioned in this GitHub Issue to figure out what to implement next. |
Here's an implementation of the Beer Song exercise. I am still missing the entry in the
config.json
file, but I'm not sure if there would be much different compared to the implementation in the Ruby track:I would be happy to make any necessary edits. Just let me know!