Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the 'Beer Song' exercise #203

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

Zureka
Copy link
Contributor

@Zureka Zureka commented Oct 9, 2019

Here's an implementation of the Beer Song exercise. I am still missing the entry in the config.json file, but I'm not sure if there would be much different compared to the implementation in the Ruby track:

    {
      "slug": "beer-song",
      "uuid": "50c34698-7767-42b3-962f-21c735e49787",
      "core": false,
      "unlocked_by": "scrabble-score",
      "difficulty": 3,
      "topics": [
        "loops",
        "strings",
        "text_formatting"
      ]
    },

I would be happy to make any necessary edits. Just let me know!

@Stargator
Copy link
Contributor

@Zureka Can you add a .meta folder that contains a file named version that contains the version number from canonical-data.json?

I'll look over this in a couple of hours.

@Stargator
Copy link
Contributor

@Zureka The config entry you posted above looks good, just place it after scrabble-score.

Copy link
Contributor

@Stargator Stargator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, after the changes be sure to run the bin/presubmit.dart file to ensure everything is correct and formatted

Copy link
Contributor

@Stargator Stargator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good, just a couple minor tweaks and I'll be ready to approve it.

Copy link
Contributor

@Stargator Stargator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zureka, would you feel comfortable squashing the three commits into one? Otherwise, I approve

@Zureka Zureka force-pushed the feature/adds-beer-song-exercise branch from 9cfb016 to 0e58846 Compare October 10, 2019 14:10
@Zureka
Copy link
Contributor Author

Zureka commented Oct 10, 2019

@Stargator I just force pushed the squashed commits. Thanks for the thorough review!

I would be willing to add more exercises after this one. I'll take a look at the exercises mentioned in this GitHub Issue to figure out what to implement next.

@Stargator Stargator merged commit 1970d10 into exercism:master Oct 10, 2019
@Stargator
Copy link
Contributor

@Zureka Feel free to check out #198 or #183 as well, that would be helpful as exercises get updated or new ones created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants