You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 11, 2022. It is now read-only.
The Input definition includes a Dictionary type, even though Dictionary doesn't seem to be used in the code and toBuffer doesn't explicitly handle it. The RLP reference hasn't mentioned anything about objects either. I was wondering if it can be removed, or there's a reason why it's there?
The text was updated successfully, but these errors were encountered:
I think Dictionary is not only not needed, but incorrect. Calling encode({a: 1123}) throws invalid type.
I believe it was added in e81acfd9571 when trying to solve #35. TS support for recursive types is non-obvious, and while googling about it I got to this comment by Anders Hejlsberg which looks almost the same as the original types.ts. This was probably copy-pasted and accidentally left here.
The
Input
definition includes aDictionary
type, even thoughDictionary
doesn't seem to be used in the code andtoBuffer
doesn't explicitly handle it. The RLP reference hasn't mentioned anything about objects either. I was wondering if it can be removed, or there's a reason why it's there?The text was updated successfully, but these errors were encountered: