Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erroneous withdrawalsroot in shanghai tests #1157

Closed
holiman opened this issue Feb 1, 2023 · 2 comments
Closed

Erroneous withdrawalsroot in shanghai tests #1157

holiman opened this issue Feb 1, 2023 · 2 comments

Comments

@holiman
Copy link
Contributor

holiman commented Feb 1, 2023

https://github.com/ethereum/tests/blob/develop/BlockchainTests/GeneralStateTests/EIPTests/stEOF/ori/CreateEOF1.json#L33

                    "uncleHash" : "0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347",
                    "withdrawalsRoot" : "0x0000000000000000000000000000000000000000000000000000000000000000"
                },

The withdrawalsroot looks wrong, and it's being rejected by geth in hive-tests: https://hivetests.ethdevops.io/suite.html?suiteid=1675224715-f273ed66dcee01023162b764a3e30373.json&suitename=consensus#test-47 .
@winsvega
Copy link
Collaborator

winsvega commented Feb 2, 2023

Looks like it was generated on geth version that didn't return withdrawals root. Need to update on newest version

@winsvega
Copy link
Collaborator

winsvega commented Feb 3, 2023

#1158

@winsvega winsvega closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@holiman @winsvega