Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the new verification flow classes into server #1824

Open
Tracked by #1665
marcocastignoli opened this issue Jan 6, 2025 · 2 comments
Open
Tracked by #1665

Integrate the new verification flow classes into server #1824

marcocastignoli opened this issue Jan 6, 2025 · 2 comments
Assignees

Comments

@marcocastignoli
Copy link
Member

marcocastignoli commented Jan 6, 2025

After finishing #1821, #1822, #1823 we can proceed and update sourcify-server to use the new verification flow.

@marcocastignoli marcocastignoli moved this from Triage to Backlog in Sourcify Public Jan 6, 2025
@kuzdogan kuzdogan moved this from Backlog to Sprint - Up Next in Sourcify Public Feb 3, 2025
@marcocastignoli marcocastignoli moved this from Sprint - Up Next to Sprint - In Progress in Sourcify Public Feb 12, 2025
@marcocastignoli
Copy link
Member Author

We have to decide what to do with the legacy verification functions in lib-sourcify.

There are two options:

  1. Delete them and devs will not upgrade to lib-sourcify@2: the con I see with this is that then we'll have to maintain two different lib-sourcify if we find any bad bug for a long time.
  2. Keep them in lib-sourcify@2: the con is that the library will contain legacy and not used code. But I don't think it's a huge problem. We can move them in a Legacy namespace marking them as deprecated and allowing an easy transition for developers.

@kuzdogan, @manuelwedler opinions?

@manuelwedler
Copy link
Contributor

We decided to not upgrade legacy lib-sourcify for bugs and drop all old functions from new lib-sourcify.

@marcocastignoli marcocastignoli moved this from Sprint - In Progress to Sprint - Blocked in Sourcify Public Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Sprint - Blocked
Development

No branches or pull requests

2 participants