Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate bytecode comparison from Travis to CircleCI #9931

Closed
cameel opened this issue Sep 30, 2020 · 3 comments
Closed

Migrate bytecode comparison from Travis to CircleCI #9931

cameel opened this issue Sep 30, 2020 · 3 comments

Comments

@cameel
Copy link
Member

cameel commented Sep 30, 2020

Related to #9258. Would also probably solve #4044.

Right now the bytecode comparison script runs on TravisCI (https://github.com/ethereum/solidity/blob/v0.7.2/.travis.yml#L208). We want to move away from Travis and move it to CircleCI.

When we move everything off Travis we'll be able to take away its write permissions to solidity repo/releases.

@cameel cameel changed the title Move bytecode comparison from Travis to CircleCI Migrate byte-code comparison jobs off Travis and take away its write permissions to solidity repo/releases Sep 30, 2020
@cameel cameel changed the title Migrate byte-code comparison jobs off Travis and take away its write permissions to solidity repo/releases Migrate bytecode comparison off Travis and take away its write permissions to solidity repo/releases Sep 30, 2020
@cameel cameel changed the title Migrate bytecode comparison off Travis and take away its write permissions to solidity repo/releases Migrate bytecode comparison off Travis Sep 30, 2020
@cameel cameel changed the title Migrate bytecode comparison off Travis Migrate bytecode comparison from Travis to CircleCI Sep 30, 2020
@cameel
Copy link
Member Author

cameel commented Sep 30, 2020

Notes from the call today:

  • Bytecode comparisons are not a part of the release process so they do not introduce a delay there, unlike the binary builds (Move release binary builds off Travis #9932).
  • The biggest issue with having it in Travis is that we can only do the check after the merge to develop.
  • Apart from just moving it, we also want to change the way it works:
    • The generated bytecode should be an artifact in CircleCI.
    • There should be a job that depends on all the jobs that produce bytecode for specific platforms and compares it. This way we can get rid of the solidity-test-bytecode repo.

@chriseth
Copy link
Contributor

Bytecode comparison is on circleci now.

@cameel
Copy link
Member Author

cameel commented Oct 30, 2020

Just for future reference, it was implemented in this PR: #10039.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants