From b01c6edc6bb23c4bda5ab24a4171b18190f7f25a Mon Sep 17 00:00:00 2001 From: Sungwoo Kim Date: Sun, 19 Feb 2023 15:14:19 -0500 Subject: [PATCH] geth/dumpconfig: fix undocumented helptext This patch documentizes the 'saving into a file' option. As suggested in #16383, piping dumpconfig's stdout is imcompatible to the Windows powershell due to the UTF16LE encoding. To fix this, #18327 (428eabe) added an option to save dumpconfig in a file. However, users cannot be informed of this feature (saving into a file) without searching the relevant github issue or seeing source code. Thus, this patch fixes the aforementioned inconvenience by improving the description of the dumpconfig's help text. fixes: 428eabe Signed-off-by: Sungwoo Kim --- cmd/geth/config.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/geth/config.go b/cmd/geth/config.go index 61b7ed5ec1e3..0b856d1c1b7a 100644 --- a/cmd/geth/config.go +++ b/cmd/geth/config.go @@ -47,10 +47,10 @@ var ( dumpConfigCommand = &cli.Command{ Action: dumpConfig, Name: "dumpconfig", - Usage: "Show configuration values", - ArgsUsage: "", + Usage: "Export configuration values in a TOML format", + ArgsUsage: "", Flags: flags.Merge(nodeFlags, rpcFlags), - Description: `The dumpconfig command shows configuration values.`, + Description: `Export configuration values in TOML format (to stdout by default).`, } configFileFlag = &cli.StringFlag{