Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI should not validate Git Submodules #4921

Closed
Pandapip1 opened this issue Mar 16, 2022 · 4 comments
Closed

Travis CI should not validate Git Submodules #4921

Pandapip1 opened this issue Mar 16, 2022 · 4 comments

Comments

@Pandapip1
Copy link
Member

See: #4835 (comment)

Currently, Travis CI validates all files - including Git Submodules which the EIP author has no control over fixing. I suggest that Travis CI parse the .gitmodules file (if it exists) and skip all files contained in submodules. This would allow EIP authors to simply add the target repository in their assets directory instead of having to provide an external link to it (discouraged by EIP-1).

The .gitmodules file will be edited every time someone adds a git submodule. The bot should not fail when this file is changed.

@MicahZoltu
Copy link
Contributor

I don't think we should allow git submodules in this repository. It adds a lot of complexity, and creates a hard dependency of this repository on some other git repository (which may move, be deleted, etc.).

@poojaranjan
Copy link
Contributor

From the discussion in the EIPIP meeting 52, it appears that EIP editors are generally not in favor of the proposal.

We will wait for other people to chime in and will be closing the issue after a week. If something comes into light later, feel free to reopen or create a new issue for discussion.

@Pandapip1
Copy link
Member Author

Closed - see ethereum-cat-herders/EIPIP#116

@Pandapip1
Copy link
Member Author

From the discussion in the EIPIP meeting 52, it appears that EIP editors are generally not in favor of the proposal.

We will wait for other people to chime in and will be closing the issue after a week. If something comes into light later, feel free to reopen or create a new issue for discussion.

Huh, this didn't show up when I sent that comment. I'll reopen for now.

@Pandapip1 Pandapip1 reopened this Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@MicahZoltu @poojaranjan @Pandapip1 and others