Examples: MQTT Connection Failure Handling.

Memory leak used was observed  when the establishment of the MQTT connection failed.

Author: kvp1703

examples/fleet_provisioning/fleet_provisioning_with_csr/main/mqtt_operations.c

@@ -853,6 +853,7 @@ bool EstablishMqttSession( MQTTPublishCallback_t publishCallback,
                     returnStatus = false;
                     LogError( ( "Connection with MQTT broker failed with status %s.",
                                 MQTT_Status_strerror( mqttStatus ) ) );
+                    Mbedtls_Pkcs11_Disconnect(pNetworkContext);
                 }
                 else
                 {

examples/jobs/main/mqtt_demo_helpers.c

@@ -833,6 +833,7 @@ int32_t EstablishMqttSession( MQTTEventCallback_t eventCallback )
                 {
                     returnStatus = EXIT_FAILURE;
                     LogError( ( "Connection with MQTT broker failed with status %u.", mqttStatus ) );
+                    xTlsDisconnect( pNetworkContext );
                 }
                 else
                 {

examples/ota/ota_http/main/ota_demo_core_http.c

@@ -1337,6 +1337,7 @@ static int establishConnection( void )
             LogError( ( "Failed creating an MQTT connection to %.*s.",
                         AWS_IOT_ENDPOINT_LENGTH,
                         AWS_IOT_ENDPOINT ) );
+            xTlsDisconnect( &networkContextMqtt );
         }
         else
         {

examples/ota/ota_mqtt/main/ota_demo_core_mqtt.c

@@ -142,7 +142,7 @@ extern const char pcAwsCodeSigningCertPem[] asm("_binary_aws_codesign_crt_start"
 /**
  * @brief Period for demo loop sleep in milliseconds.
  */
-#define OTA_EXAMPLE_LOOP_SLEEP_PERIOD_MS    ( 5U )
+#define OTA_EXAMPLE_LOOP_SLEEP_PERIOD_MS    ( 20U )
 
 /**
  * @brief Size of the network buffer to receive the MQTT message.
@@ -1207,6 +1207,7 @@ static int establishConnection( void )
             LogError( ( "Failed creating an MQTT connection to %.*s.",
                         AWS_IOT_ENDPOINT_LENGTH,
                         AWS_IOT_ENDPOINT ) );
+            xTlsDisconnect(&networkContext);
         }
         else
         {
@@ -1573,6 +1574,8 @@ static void * otaThread( void * pParam )
     return NULL;
 }
 /*-----------------------------------------------------------*/
+uint32_t otaPacketsReceived_prev = 0;
+
 static int startOTADemo( void )
 {
     /* Status indicating a successful demo or not. */
@@ -1707,7 +1710,13 @@ static int startOTADemo( void )
                                otaStatistics.otaPacketsDropped ) );
 
                     /* Delay to allow data to buffer for MQTT_ProcessLoop. */
-                    Clock_SleepMs( OTA_EXAMPLE_LOOP_SLEEP_PERIOD_MS );
+
+                    if (otaStatistics.otaPacketsReceived == otaPacketsReceived_prev) {
+                        Clock_SleepMs( OTA_EXAMPLE_LOOP_SLEEP_PERIOD_MS );
+                    }
+
+                    otaPacketsReceived_prev = otaStatistics.otaPacketsReceived;
+
                 }
                 else
                 {

examples/thing_shadow/main/shadow_demo_helpers.c

@@ -832,6 +832,7 @@ int32_t EstablishMqttSession( MQTTEventCallback_t eventCallback )
                 {
                     returnStatus = EXIT_FAILURE;
                     LogError( ( "Connection with MQTT broker failed with status %u.", mqttStatus ) );
+                    xTlsDisconnect( pNetworkContext );
                 }
                 else
                 {