Pointer<->Int casts are not constexpr (#8796)

mcspr · web-flow · commit df59774eb50b · 2023-01-09T21:07:57.000+03:00
diff --git a/cores/esp8266/esp_priv.h b/cores/esp8266/esp_priv.h
@@ -23,9 +23,8 @@
 
 #if defined(CORE_MOCK)
 
-constexpr bool __byteAddressable(const void* addr)
+constexpr bool __byteAddressable(const void*)
 {
-    (void)addr;
     return true;
 }
 
@@ -34,7 +33,7 @@ constexpr bool __byteAddressable(const void* addr)
 #include <sys/config.h>
 
 // returns true when addr can be used without "pgm_" functions or non32xfer service
-constexpr bool __byteAddressable(const void* addr)
+inline bool __byteAddressable(const void* addr)
 {
     return addr < (const void*)(XCHAL_DATARAM0_VADDR + XCHAL_DATARAM0_SIZE);
 }

Original file line number	Diff line number	Diff line change
`@@ -23,9 +23,8 @@`
`23`	`23`
`24`	`24`	`#if defined(CORE_MOCK)`
`25`	`25`
`26`		`-constexpr bool __byteAddressable(const void* addr)`
	`26`	`+constexpr bool __byteAddressable(const void*)`
`27`	`27`	`{`
`28`		`- (void)addr;`
`29`	`28`	`return true;`
`30`	`29`	`}`
`31`	`30`
`@@ -34,7 +33,7 @@ constexpr bool __byteAddressable(const void* addr)`
`34`	`33`	`#include <sys/config.h>`
`35`	`34`
`36`	`35`	`// returns true when addr can be used without "pgm_" functions or non32xfer service`
`37`		`-constexpr bool __byteAddressable(const void* addr)`
	`36`	`+inline bool __byteAddressable(const void* addr)`
`38`	`37`	`{`
`39`	`38`	`return addr < (const void*)(XCHAL_DATARAM0_VADDR + XCHAL_DATARAM0_SIZE);`
`40`	`39`	`}`