Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix write-bin for files whose lengths are not divisible by 4 by padding FF bytes #780

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Fix write-bin for files whose lengths are not divisible by 4 by padding FF bytes #780

merged 2 commits into from
Feb 25, 2025

Conversation

JurajSadel
Copy link
Contributor

closes #698

SergioGasquez
SergioGasquez approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

Seems like clippy is angry, but those lints are resolved in #779

@SergioGasquez
Copy link
Member

#782 fixes clippy errors, I guess we can rebase this PR once the merge queue finishes the merge

jessebraham
jessebraham approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jessebraham jessebraham added this pull request to the merge queue Feb 25, 2025
Merged via the queue into esp-rs:main with commit 473701c Feb 25, 2025
24 checks passed
@JurajSadel JurajSadel deleted the write-bin branch February 25, 2025 14:03
@SergioGasquez SergioGasquez mentioned this pull request Feb 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

write-bin truncates data when length not divisible by 4
3 participants
@JurajSadel @SergioGasquez @jessebraham