Add watchdog reset experiment #779
Open
+228
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
reviewed
Feb 21, 2025
JurajSadel
force-pushed
the
jtag-reset
branch
from
4471afb to
e20dfd9
Compare
|
Should I add a P4 here as well? |
JurajSadel
force-pushed
the
jtag-reset
branch
from
47aacaf to
e3544c6
Compare
jessebraham
reviewed
Feb 26, 2025
| fn wdt_config1(&self) -> u32; | ||
| } | ||
|
|
||
| impl RtcWdtReset for crate::targets::esp32c3::Esp32c3 { |
There was a problem hiding this comment.
I would really like to avoid leaking chip-specific details like these into other modules, this all probably belongs in the targets module.
jessebraham
reviewed
Feb 26, 2025
|
|
||
| #[cfg(feature = "serialport")] | ||
| /// Check if the connection is USB OTG | ||
| pub(crate) fn connection_is_usb_otg(&self, connection: &mut Connection) -> Result<bool, Error> { |
There was a problem hiding this comment.
This function feels like it belongs on the Connection struct, so we should probably expose the necessary details from the targets module which can then be referenced there.
This applies to the other functions in the targets module below as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly experimental, so opening as a draft.
I've been playing with (cc cc #691) and I was able to reproduce the issue with espflash AND esptool as well, following the same steps as mentioned here
I looked into esptool and specifically to this commit.
esptoolnot using this fix as default for SERIAL_JTAG, it can be used manually with:--after reset_watchdogThe reasons (from esptool perspective) it's not on by default are: