Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update default partition tables for each target device #784

Open
jessebraham opened this issue Feb 26, 2025 · 3 comments
Open
Milestone

Comments

@jessebraham
Copy link
Member

As a result of #617 I discovered that for the ESP32-S3 the default factory partition is set to 1MB, which is unnecessarily small. This should be increased, but we should also review the other target devices and ensure that reasonable default settings are being used.

@jessebraham jessebraham added this to the v4 milestone Feb 26, 2025
@MabezDev
Copy link
Member

Given that we can detect flash size, maybe we can just set the default partition table to the size of flash?

@jessebraham
Copy link
Member Author

The save-image subcommand does not require a device to be connected, so we still need some default value with how things are currently structured. Perhaps we can change this, but I have not investigated this yet so am not sure whether or not that's feasible.

@MabezDev
Copy link
Member

Ah I see, that does indeed complicate things :D. IIRC, the smallest flash size we offer with our chips is 2MB, so at the very least we should be able to bump the default for 2MB for save-image or for situations where flash size can't be detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants