Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest release candidate of embedded-hal{-async,-nb} #994

Merged
merged 6 commits into from
Dec 8, 2023

Conversation

jessebraham
Copy link
Member

@jessebraham jessebraham commented Dec 4, 2023

Not really sure about the implementation of DelayNs as that's a pretty small time slice relative to our CPUs' frequencies, but I've just basically copied from riscv. Should be fine, I think.

Otherwise, pretty straight-forward change.

Waiting on a new embassy-time release still, so will need to update that and remove the patch when it's available.

@jessebraham
Copy link
Member Author

Oh, good timing. New embassy-time release is out, updating...

@jessebraham
Copy link
Member Author

Just waiting on a new release of embassy-executor now...

@jessebraham jessebraham marked this pull request as draft December 4, 2023 14:38
@jessebraham jessebraham force-pushed the feature/embedded-hal-rc2 branch from c563217 to 0124422 Compare December 4, 2023 14:52
@jessebraham jessebraham changed the title Update to latest release canadidate of embedded-hal{-async,-nb} Update to latest release candidate of embedded-hal{-async,-nb} Dec 5, 2023
@jessebraham jessebraham force-pushed the feature/embedded-hal-rc2 branch from 86a0fe5 to 232e128 Compare December 7, 2023 20:01
@jessebraham jessebraham marked this pull request as ready for review December 7, 2023 20:02
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev added this pull request to the merge queue Dec 8, 2023
Merged via the queue into esp-rs:main with commit 1130ae4 Dec 8, 2023
@jessebraham jessebraham deleted the feature/embedded-hal-rc2 branch December 8, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants