Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SpiBusDevice and SpiBusController #978

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Remove SpiBusDevice and SpiBusController #978

merged 2 commits into from
Nov 28, 2023

Conversation

bugadani
Copy link
Contributor

I believe there exist enough alternatives to remove a few lines of code from the spi HAL.

@bugadani bugadani force-pushed the bus branch 2 times, most recently from 934a2fe to dc565e9 Compare November 27, 2023 17:13
jessebraham
jessebraham approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham added this pull request to the merge queue Nov 28, 2023
Merged via the queue into esp-rs:main with commit 4a0af66 Nov 28, 2023
@bugadani bugadani deleted the bus branch December 5, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bugadani @jessebraham