H2: Add initial ADC support with example #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did some very simple tests and it seems to work fine for me |
JurajSadel
force-pushed
the
feature/esp32h2-adc
branch
from
dd283a9 to
e7ba5c2
Compare
jessebraham
approved these changes
May 31, 2023
MabezDev
pushed a commit
to MabezDev/esp-hal
that referenced
this pull request
Jun 1, 2023
* H2: Add initial ADC support with example * Add changelog
SergioGasquez
pushed a commit
to SergioGasquez/esp-hal
that referenced
this pull request
Jun 9, 2023
* H2: Add initial ADC support with example * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have
analoggpios and other stuff, so this just adds an example and export inprelude.There is no calibration yet, we should wait for the calibration PR(#555) to be merged and we can address it afterward.
H2 calibration is currently not implemented in ESP-IDF (IDF-6216)