[3/3] Timer abstraction: cleanup, simplification, and documentation #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
requested changes
May 27, 2024
jessebraham
force-pushed
the
feature/timer-abstraction-2
branch
from
6f46c66 to
44b1364
Compare
|
Really questioning the value of clippy these days... 😓 |
bjoernQ
reviewed
May 28, 2024
bjoernQ
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should wrap up my work on the timer abstraction layer. This PR still needs testing, as I have changed some APIs a bit and as such they need confirmation. However, I think everything should be in okay shape.
The documentation definitely could use some improving, but I was struggling to come up with what more I could write or some better examples. Open to any input here, but perhaps that can be improved in another PR by somebody else instead.
I don't think this really needs a
CHANGELOG.mdentry, but let me know if I've missed anything; happy to add one if needed.Closes #1479.