Make examples less dependent on embedded-hal where able
#1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
reviewed
Mar 25, 2024
| @@ -362,6 +363,10 @@ pub fn build_package( | |||
| builder = builder.features(&features); | |||
| } | |||
|
|
|||
| if no_default_features { | |||
| builder = builder.arg("--no-default-features"); | |||
jessebraham
changed the title
embedded-hal where able
yanshay
pushed a commit
to yanshay/esp-hal
that referenced
this pull request
Mar 25, 2024
* Add support for building a package without its default features to `xtask` * Do not require `embedded_hal_02` traits in examples where they are not required * Do not require `embedded_hal_02` traits for filling a buffer with random bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small start towards #1317:
xtaskrngdriver to be less dependent on trait implsembedded_hal_02in examples where it is not requiredThe remaining drivers likely will not be so trivial to decouple, so I figured I'd just get these out of the way before I start digging into those.