Create safe wrappers for some ROM functions in the rom module
#1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
requested changes
Mar 14, 2024
SergioGasquez
approved these changes
Mar 14, 2024
|
@SergioGasquez thanks, but there is so much cleanup that needs to be done in some of these modules I'm not going to worry about that stuff right now 😁 |
jessebraham
force-pushed
the
experiment/rom-api
branch
from
7aa8461 to
70d44e7
Compare
6 tasks
yanshay
pushed a commit
to yanshay/esp-hal
that referenced
this pull request
Mar 16, 2024
…rs#1290) * Create safe wrappers for some ROM functions in the `rom` module * Replace transmute in ESP32-S3's `cpu_control` module with ROM function * Inline *all* the things! * Remove duplicate of `rom::regi2c_write` with ROM function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is basically to provide consistent APIs (as consistent as possible, as least) for our ROM functions, contained within the
rommodule. Rather than having a bunch of externs and unsafe blocks throughout our drivers, we can simply define safe wrappers within this module.There are still some lingering
extern "C" {}blocks in the code base, but they're generally pretty specific to a peripheral and chip, so I've left them for now.(Some unrelated cleanup got mixed in here, sorry for the noise)