Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tooling and Writing Your Own Application chapters #81

Merged

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Apr 18, 2023

Copy link
Contributor

@f-hollow f-hollow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergioGasquez

Left some comments. Please disregard whatever is not useful or applicable.

Also, suggest reviewing the comments from the respective chapters on HackMD.

@SergioGasquez SergioGasquez changed the base branch from main to overhaul April 25, 2023 09:41
Copy link
Contributor

@f-hollow f-hollow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about the Writing Your Own Application section.

- A call to `esp_idf_sys::link_patches` function that makes sure that a few patches to the ESP-IDF which are implemented in Rust are linked to the final executable.
- We print in our console the famous "Hello World!".

## Running the Code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section looks very similar to its counterpart in Understanding esp-template (maybe even the same).

Do you think it is better to have it in one place from the maintenance perspective? If the differences are small, maybe it is worth only covering the differences here?

Just an idea, so feel free to ignore it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you mean the "Running the Code" section, if so, the logs after flashing the project are quite different and I dont think it makes much sense to unify them


Using `cargo run` will compile the project, flash it, and open a serial monitor with our chip.

## Using Dev Containers in the templates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there are some instructions in esp-rs/esp-template. I skimmed through them, and they look serious.

As an idea, it might be great to have a tutorial about using Dev Containers in VS Code with the templates. Projects with Dev Containers are usually very good for beginners.

If I missed something or if it is irrelevant, please consider it as noise.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there are some instructions in esp-rs/esp-template. I skimmed through them, and they look serious.

What do you mean by "they look serious"? We have some devcontainers documentation in both templates:

Copy link
Contributor

@f-hollow f-hollow May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By "too serious", I mean that it looks like normal documentation as it should of course. It has links to other resources that you might choose to go through and other things that you can do.

A tutorial might be good from the perspective that you define a goal -- the result of the effort -- and lead the reader to this goal directly using only the instructions needed to achieve this goal without any additional information. The bottom line is the reader opening the document, following the steps without the need to make choices, and having a sample project completed by themselves with some desired result. Most likely, it can be a separate document or part of some book.

Again, like I said, it is just an idea off the top of my head which might be useful or might be completely irrelevant. You know the subject better, so you decide.

Copy link
Contributor

@f-hollow f-hollow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments about the Tooling chapter.

SergioGasquez and others added 8 commits May 11, 2023 15:58
Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>
Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>
Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>
@SergioGasquez SergioGasquez marked this pull request as ready for review May 12, 2023 12:46
@f-hollow
Copy link
Contributor

@SergioGasquez

Thank you for reacting to all my comments. LGTM!

@SergioGasquez SergioGasquez merged commit 00afff6 into esp-rs:overhaul May 30, 2023
@SergioGasquez SergioGasquez deleted the feature/application-chapter branch May 30, 2023 08:06
SergioGasquez added a commit to SergioGasquez/book that referenced this pull request May 30, 2023
* feat: ✨ Update chapter order

* feat: ✨ Add tooling note

* feat: ✨ Update pormpts, console outputs and dev container info

* chore: 🔥 Remove hello-world chapter

* chore: 🔥 Remove hello-world chapter

* feat: ✨ Update information to current state of the template

* feat: ✨ Update panic outputs

* chore: 🔥 Remove hello-world chapter

* feat: ✨ Update blinky code

* feat: ✨ Update button code

* feat: ✨ Update interrupt code

* style: 🎨 Remove personal paths

* style: 🎨 Use uppercase

* feat: ✨ Update esp-idf-template chapter

* feat: ✨ Update espflash chapter

* feat: ✨ Update tooling intro

* feat: ✨ Update VsCode chapter

* chore: 🔥 Remove espmonitor

* Update src/tooling/index.md

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* Update src/writing-your-own-application/index.md

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* docs: 🎨 Update links

* docs: 🎨 List possible ways of creating an app

* docs: 📝 Reformat as list of instructions

* docs: 📝 Remove unnecesary logs

* docs: 📝 Add wokwi vs code section

* docs: 🐛 Fix typo

* docs: ⚡️ Update esp-template with new prompts

* docs: 📝 Improve note about next chapters

* docs: 📝 Update undestanding templates chapters

* docs: 📝 Update Wokwi documentation

* docs: 📝 Move note about cargo generate

* docs: 🎨 Format prompt answers

* docs: 🐛 Fix custom runner command

* docs: 📝 Update espflash section

* docs: 📝 Add support tables for simlating and debugging

* docs: 📝 Update applications section

* docs: 🐛 Fix links

* docs: 🐛 Fix links

* docs: 🐛 Fix links

* docs: 📝 Add note about generating project with Cargo

* docs: 📝 LT suggestions

* docs: 📝 Update esp-idf-hal links

* docs: 📝 Use listing and expand how to build/run templates+

* docs: 📝 Add link to main.rs section

* docs: 📝 Remove next section paragraph

* docs: 📝 Be consistent in template projects name

* docs: 📝 Update section name

* docs: Add comma

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* docs: Fix typo

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* docs: Clarify custom chips

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* docs: 📝 Avoid listing all the supported chips

* docs: ⚡️ Update debbuging support table

* docs: 📝 Apply LT suggestions

* docs: 📝 Apply LT suggestions

* docs: ✨ Add no_std book links

---------

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>
SergioGasquez added a commit to SergioGasquez/book that referenced this pull request May 31, 2023
* feat: ✨ Update chapter order

* feat: ✨ Add tooling note

* feat: ✨ Update pormpts, console outputs and dev container info

* chore: 🔥 Remove hello-world chapter

* chore: 🔥 Remove hello-world chapter

* feat: ✨ Update information to current state of the template

* feat: ✨ Update panic outputs

* chore: 🔥 Remove hello-world chapter

* feat: ✨ Update blinky code

* feat: ✨ Update button code

* feat: ✨ Update interrupt code

* style: 🎨 Remove personal paths

* style: 🎨 Use uppercase

* feat: ✨ Update esp-idf-template chapter

* feat: ✨ Update espflash chapter

* feat: ✨ Update tooling intro

* feat: ✨ Update VsCode chapter

* chore: 🔥 Remove espmonitor

* Update src/tooling/index.md

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* Update src/writing-your-own-application/index.md

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* docs: 🎨 Update links

* docs: 🎨 List possible ways of creating an app

* docs: 📝 Reformat as list of instructions

* docs: 📝 Remove unnecesary logs

* docs: 📝 Add wokwi vs code section

* docs: 🐛 Fix typo

* docs: ⚡️ Update esp-template with new prompts

* docs: 📝 Improve note about next chapters

* docs: 📝 Update undestanding templates chapters

* docs: 📝 Update Wokwi documentation

* docs: 📝 Move note about cargo generate

* docs: 🎨 Format prompt answers

* docs: 🐛 Fix custom runner command

* docs: 📝 Update espflash section

* docs: 📝 Add support tables for simlating and debugging

* docs: 📝 Update applications section

* docs: 🐛 Fix links

* docs: 🐛 Fix links

* docs: 🐛 Fix links

* docs: 📝 Add note about generating project with Cargo

* docs: 📝 LT suggestions

* docs: 📝 Update esp-idf-hal links

* docs: 📝 Use listing and expand how to build/run templates+

* docs: 📝 Add link to main.rs section

* docs: 📝 Remove next section paragraph

* docs: 📝 Be consistent in template projects name

* docs: 📝 Update section name

* docs: Add comma

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* docs: Fix typo

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* docs: Clarify custom chips

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* docs: 📝 Avoid listing all the supported chips

* docs: ⚡️ Update debbuging support table

* docs: 📝 Apply LT suggestions

* docs: 📝 Apply LT suggestions

* docs: ✨ Add no_std book links

---------

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>
SergioGasquez added a commit that referenced this pull request Jun 6, 2023
* docs: Add Rust documentation style guide (#79)

* docs: Add Rust documentation style guide

(cherry picked from commit f7a307a)

* Add missing extension to rust-doc-style-quide

* Update the Terminology chapter

* Add details on using the terms ESP-IDF and esp-idf

* Add more terms

* Add note on not using italics with Espressif product names

* Improve guidelines on where to add link variables

* Add guideine to apply monospace to image and container names

* Add section on admonitions

* Fix markdown formatting issues

---------

Co-authored-by: Kirill Chalov <kirill.chalov@espressif.com>

* Update Tooling and Writing Your Own Application chapters (#81)

* feat: ✨ Update chapter order

* feat: ✨ Add tooling note

* feat: ✨ Update pormpts, console outputs and dev container info

* chore: 🔥 Remove hello-world chapter

* chore: 🔥 Remove hello-world chapter

* feat: ✨ Update information to current state of the template

* feat: ✨ Update panic outputs

* chore: 🔥 Remove hello-world chapter

* feat: ✨ Update blinky code

* feat: ✨ Update button code

* feat: ✨ Update interrupt code

* style: 🎨 Remove personal paths

* style: 🎨 Use uppercase

* feat: ✨ Update esp-idf-template chapter

* feat: ✨ Update espflash chapter

* feat: ✨ Update tooling intro

* feat: ✨ Update VsCode chapter

* chore: 🔥 Remove espmonitor

* Update src/tooling/index.md

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* Update src/writing-your-own-application/index.md

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* docs: 🎨 Update links

* docs: 🎨 List possible ways of creating an app

* docs: 📝 Reformat as list of instructions

* docs: 📝 Remove unnecesary logs

* docs: 📝 Add wokwi vs code section

* docs: 🐛 Fix typo

* docs: ⚡️ Update esp-template with new prompts

* docs: 📝 Improve note about next chapters

* docs: 📝 Update undestanding templates chapters

* docs: 📝 Update Wokwi documentation

* docs: 📝 Move note about cargo generate

* docs: 🎨 Format prompt answers

* docs: 🐛 Fix custom runner command

* docs: 📝 Update espflash section

* docs: 📝 Add support tables for simlating and debugging

* docs: 📝 Update applications section

* docs: 🐛 Fix links

* docs: 🐛 Fix links

* docs: 🐛 Fix links

* docs: 📝 Add note about generating project with Cargo

* docs: 📝 LT suggestions

* docs: 📝 Update esp-idf-hal links

* docs: 📝 Use listing and expand how to build/run templates+

* docs: 📝 Add link to main.rs section

* docs: 📝 Remove next section paragraph

* docs: 📝 Be consistent in template projects name

* docs: 📝 Update section name

* docs: Add comma

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* docs: Fix typo

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* docs: Clarify custom chips

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* docs: 📝 Avoid listing all the supported chips

* docs: ⚡️ Update debbuging support table

* docs: 📝 Apply LT suggestions

* docs: 📝 Apply LT suggestions

* docs: ✨ Add no_std book links

---------

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* docs: 📝 Update links to STD trainings

* fix: Fix typo

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* fix: Format commas

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* fix: Format commas

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* fix: Clarify wording

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>

* feat: ✨ Update title and add link for Rust book style guides

* style: 🎨 Rename document

* docs: 📝 Update the Rust Style guide links to the main repo

---------

Co-authored-by: Kirill <105578077+f-hollow@users.noreply.github.com>
Co-authored-by: Kirill Chalov <kirill.chalov@espressif.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants