Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add types to package #179

Merged
merged 10 commits into from
Feb 21, 2025
Merged

feat: Add types to package #179

merged 10 commits into from
Feb 21, 2025

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Feb 12, 2025

Builds on #178 to include types in the package:

  • Add type definitions (copied from @types/eslint__eslintrc)
  • Add type tests
  • Run type tests in CI

This eliminates the need for @types/eslint__eslintrc.

@nzakas nzakas marked this pull request as ready for review February 19, 2025 18:19
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime
Copy link
Member

I'll leave this open until today's release in case someone else would like to review.

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, actually the path of the .d.ts file in package.json is wrong. I was wondering why VSCode wasn't finding the new types locally.

Co-authored-by: Francesco Trotta <github@fasttime.org>
@nzakas
Copy link
Member Author

nzakas commented Feb 21, 2025

Good catch!

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Going to merge now.

@fasttime fasttime merged commit cb546be into main Feb 21, 2025
13 checks passed
@fasttime fasttime deleted the pkg-types branch February 21, 2025 19:10
@github-actions github-actions bot mentioned this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants