Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evmone: missing specific error string for OOG in call_impl #2761

Open
Sixtysixter opened this issue Feb 28, 2025 · 0 comments
Open

evmone: missing specific error string for OOG in call_impl #2761

Sixtysixter opened this issue Feb 28, 2025 · 0 comments

Comments

@Sixtysixter
Copy link
Contributor

Sixtysixter commented Feb 28, 2025

Calling

{
  "jsonrpc":"2.0",
  "method":"debug_traceTransaction",
  "params":[
     "0x75f027631056616468a13d3bf83c08a2f7ce803bb20b8d980c9d73bdbd5ce355",
     {"disableStorage": true,"disableMemory": true,"disableStack": true}
  ],
  "id":1
}

the silkworm RPC JSON result differs from erigon in the trace error field for opcode CALL at PC 244 (depth 2.
That's due to the check made in call_impl.

The call_impl function returns false We would need to receive also an error string indicating the specific reason for the OOG error.

Current JSON result:

      {
        "depth": 2,
        "error": "out of gas",
        "gas": 8216,
        "gasCost": 40,
        "op": "CALL",
        "pc": 244
      }

Expected JSON result:

      {
        "depth": 2,
        "error": "out of gas: gas uint64 overflow",
        "gas": 8216,
        "gasCost": 40,
        "op": "CALL",
        "pc": 244
      }

The related integration tests are test_62, test_74, test_75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant