Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSZ tests after data_gas_used was added #7640

Closed
yperbasis opened this issue Jun 2, 2023 · 2 comments
Closed

Fix SSZ tests after data_gas_used was added #7640

yperbasis opened this issue Jun 2, 2023 · 2 comments
Assignees
@Giulio2002
Labels
Dencun

Comments

@yperbasis
Copy link
Member

v1.4.0-alpha.1 of the consensus specs adds data_gas_used to the header and changes data_gas_used from uint256 to uint64. PR #7639 implements the change, but w/o the necessary updates to the SSZ tests, whose embed SSZ serialization is obsolete now. Namely, the following tests need to be updated:

  • TestHashTreeRoot
  • TestGetters
  • TestBlockProcessingDeneb
  • TestEncodeDecode
@Giulio2002
Copy link
Contributor

Fixed by #7650

@Giulio2002
Copy link
Contributor

hippity hoppity, your issue is my property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Giulio2002 Giulio2002

Labels
Dencun
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@VBulikov @Giulio2002 @yperbasis