This repository has been archived by the owner on Nov 19, 2020. It is now read-only.
Include statusCode when failure to unmarshal #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this issue is related to #46 |
|
lgtm, thanks! |
conorbranagan
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Oct 10, 2017
* The latest version of the library includes better logging for errors which include the status code. See ericchiang/k8s#58 * The deployment API is unavailable in older versions of Kubernetes. We don't really _need_ this information since we can parse it from the ReplicaSet name.
masci
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Oct 12, 2017
* [k8s] Update library, allow deployment API to fail * The latest version of the library includes better logging for errors which include the status code. See ericchiang/k8s#58 * The deployment API is unavailable in older versions of Kubernetes. We don't really _need_ this information since we can parse it from the ReplicaSet name. * [k8s] Import log package in metadata provider
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We experienced a bit of trouble debugging when the
unmarshalfailed. We were getting the following error message:We eventually realized it was because the body simply contained
Unauthorized. But had thestatusCodebeen included in the error message we would have realized this much quicker.So this simply updates the unmarshal error message to include the
statusCodealong with the unmarshal error message.