Skip to content
This repository has been archived by the owner on Nov 19, 2020. It is now read-only.

Consider adding yaml tags on Config struct #60

Closed
sunshinekitty opened this issue Oct 25, 2017 · 2 comments
Closed

Consider adding yaml tags on Config struct #60

sunshinekitty opened this issue Oct 25, 2017 · 2 comments

Comments

@sunshinekitty
Copy link

Currently there are just json tags, this is not an issue with github.com/ghodss/yaml since it does yaml -> json before unmarshalling, but if you're not using this package you will find things don't unmarshal correctly.

@JorritSalverda
Copy link
Contributor

I tested locally with the yaml tags, but with gopkg.in/yaml.v2 it fails to unmarshal certificate-authority-data into a []byte. So it's not as simple as just adding the tags.

With github.com/ghodss/yaml@v1.0.0 and no yaml tags it worked fine though.

@ericchiang
Copy link
Owner

#71 has been merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants