Merge pull request #295 from open-source-contributions/test_enhancement

localheinz · web-flow · commit b6e01806d5e0 · 2020-12-14T08:17:18.000+01:00
Make assert equals strict
diff --git a/test/Unit/RuleSet/AbstractRuleSetTestCase.php b/test/Unit/RuleSet/AbstractRuleSetTestCase.php
@@ -45,7 +45,7 @@ final public function testDefaults(): void
 
         self::assertSame($this->name, $ruleSet->name());
         self::assertEquals($this->rules, $ruleSet->rules());
-        self::assertEquals($this->targetPhpVersion, $ruleSet->targetPhpVersion());
+        self::assertSame($this->targetPhpVersion, $ruleSet->targetPhpVersion());
     }
 
     final public function testRuleSetDoesNotConfigureRuleSets(): void

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ final public function testDefaults(): void`
`45`	`45`
`46`	`46`	`self::assertSame($this->name, $ruleSet->name());`
`47`	`47`	`self::assertEquals($this->rules, $ruleSet->rules());`
`48`		`- self::assertEquals($this->targetPhpVersion, $ruleSet->targetPhpVersion());`
	`48`	`+ self::assertSame($this->targetPhpVersion, $ruleSet->targetPhpVersion());`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`final public function testRuleSetDoesNotConfigureRuleSets(): void`