Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer Firefox over Chrome #378

Closed
asnyv opened this issue Jan 20, 2021 · 3 comments · Fixed by #388
Closed

Prefer Firefox over Chrome #378

asnyv opened this issue Jan 20, 2021 · 3 comments · Fixed by #388

Comments

@asnyv
Copy link
Collaborator

asnyv commented Jan 20, 2021

After #374 we don't need webviz certificate --auto-install anymore.
Switching the preferred browser to firefox, unless overruled by webviz preferences, will make the conversion on localhost smoother, as no actions are required by the end user due to the certificate change.

for browser in ["chrome", "chromium-browser"]:
try:
return webbrowser.get(using=browser)
except webbrowser.Error:
pass

@pinkwah
Copy link
Contributor

pinkwah commented Jan 20, 2021

I'll think about whether it's possible to solve #288 instead. We'd rather use the user's default browser unless it's too old, in which case we provide eg. Firefox. This isn't something that's possible to do via the webbrowser module since it's a bit dumb, but could perhaps be possible with some extra Python code.

@asnyv
Copy link
Collaborator Author

asnyv commented Jan 20, 2021

@dotfloat 👍 Think we'll have to do at least one of them before the next release to make the transition as smooth as possible.
But to add Firefox as preferred is of course super simple, so can wait until we are close to feature freeze.

@pinkwah
Copy link
Contributor

pinkwah commented Jan 20, 2021

I agree. We could probably just do Firefox now and then later on do #288.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants