Skip to content

Commit 623ab6f

Browse files
authored
typing-extensions not needed on py38+ (#284)
1 parent 4f373a2 commit 623ab6f

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

.github/workflows/webviz-config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ jobs:
6363
run: pip freeze
6464

6565
- name: 🕵️ Check code style & linting
66-
if: matrix.pandas-version == '1.*'
66+
if: matrix.pandas-version == '1.*' && matrix.python-version == '3.8'
6767
run: |
6868
black --check webviz_config tests setup.py
6969
pylint webviz_config tests setup.py

setup.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@
4646
"pyarrow>=0.16",
4747
"pyyaml>=5.1",
4848
"tqdm>=4.8",
49-
"importlib_metadata>=1.7; python_version<'3.8'",
50-
"typing-extensions>=3.7", # Needed on Python < 3.8
49+
"importlib-metadata>=1.7; python_version<'3.8'",
50+
"typing-extensions>=3.7; python_version<'3.8'",
5151
"webviz-core-components>=0.0.19",
5252
],
5353
tests_require=TESTS_REQUIRES,

webviz_config/_docs/_build_docs.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,13 @@
2222
# Python 3.8+
2323
# pylint: disable=ungrouped-imports
2424
from importlib.metadata import version # type: ignore
25-
except ModuleNotFoundError:
25+
from typing import TypedDict # type: ignore
26+
except (ImportError, ModuleNotFoundError):
2627
# Python < 3.8
2728
from importlib_metadata import version # type: ignore
29+
from typing_extensions import TypedDict # type: ignore
2830

2931
import jinja2
30-
from typing_extensions import TypedDict
3132

3233
import webviz_config.plugins
3334
from webviz_config._config_parser import SPECIAL_ARGS

0 commit comments

Comments
 (0)