Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmudesign: singular correlation matrix #684

Open
runhol opened this issue Jan 29, 2025 · 4 comments
Open

fmudesign: singular correlation matrix #684

runhol opened this issue Jan 29, 2025 · 4 comments

Comments

@runhol
Copy link

runhol commented Jan 29, 2025

The latest fmudesign uses transformation of correlated variables via Cholesky factorization. To perform the Cholesky
factorization the matrix has to be symmetric positive definite (non-singular), Could this be generalized to the case
of singular correlation matrices (symmetric positive semidefinite) by using f.ex. SVD instead of Cholesky?

@dafeda
Copy link
Contributor

dafeda commented Feb 3, 2025

I think this is technically possible, but not sure it's something that we want to do.
One way the correlation matrix becomes singular is if two or more variables are 100% correlated.
When do we want to model using 100% correlated variables?
Great if @tralsos can chip in here.

@tralsos
Copy link
Contributor

tralsos commented Feb 3, 2025

I think the use case for 100% correlated variables is there. E.g. you have a case where want to test what is the oil water contact in two segments is the same, compared to that they vary independently. Or you have some prediction parameters that are correlated, but you want to test what happens if they are 100% correlated.

@azizovilgar7
Copy link

I have a similar issue using it, as we have some cases similar to what Trine mentioned.

@tralsos
Copy link
Contributor

tralsos commented Feb 28, 2025

Input from Gyrid Johnsen:

Correlation 1 is (often) used for FWL and GOC uncertainties.
I have encountered this issue in two different projects lately (and luckily I knew of the change on fmudesign)

  1. In one solved by setting a constant dummy number (-999) in design input and copying the relevant columns in the final design matrix
  2. In the other by setting correlation 0.99999 and having no decimals in the output.
  3. Can also be solved with @risk or by scripting.
    Solution 1) requires manual steps – solution 2 is ok if you don’t need decimals - solution 3) is not transparent.
    So it would help a lot of projects if this feature is “fixed”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants