Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmudesign: Detect merged cells in design matrix #667

Open
tralsos opened this issue Mar 6, 2020 · 3 comments
Open

fmudesign: Detect merged cells in design matrix #667

tralsos opened this issue Mar 6, 2020 · 3 comments
Labels
christmas-review Issues and PRs for Christmas review fmudesign question Further information is requested wontfix This will not be worked on

Comments

@tralsos
Copy link
Contributor

tralsos commented Mar 6, 2020

If users have merged Excel cells in their input to the design matrix, this can lead to hard-to-understand error messages.
It is possible to detect merged cells in an Excel sheet and warn the user that this is not recommended, and unexpected behaviour should be expected.

@berland
Copy link
Collaborator

berland commented Mar 6, 2020

@tralsos
Copy link
Contributor Author

tralsos commented Mar 13, 2020

When reading the design_input into a pandas dataframe empty cells and merged cells are both read as NaN, There will always be empty cells, so not sure how to separate those from merged cells.

@berland
Copy link
Collaborator

berland commented Mar 16, 2020

Let's put on hold until we find a solution. Probably not doable with Pandas directly, possibly with coding the excel -> dataframe conversion manually with openpyxl, which is probably some work.

@berland berland added wontfix This will not be worked on question Further information is requested labels Mar 16, 2020
@dafeda dafeda transferred this issue from equinor/fmu-tools Nov 28, 2024
@eivindjahren eivindjahren added the christmas-review Issues and PRs for Christmas review label Dec 13, 2024
@sondreso sondreso added this to SCOUT Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
christmas-review Issues and PRs for Christmas review fmudesign question Further information is requested wontfix This will not be worked on
Projects
Status: No status
Development

No branches or pull requests

4 participants