diff --git a/source/exe/platform_impl.h b/source/exe/platform_impl.h index c52152c8fe6d..4c05dff22584 100644 --- a/source/exe/platform_impl.h +++ b/source/exe/platform_impl.h @@ -8,6 +8,7 @@ namespace Envoy { class PlatformImpl { public: PlatformImpl(); + ~PlatformImpl(); Thread::ThreadFactory& threadFactory() { return *thread_factory_; } Filesystem::Instance& fileSystem() { return *file_system_; } diff --git a/source/exe/posix/platform_impl.cc b/source/exe/posix/platform_impl.cc index f664071815ee..8fc227724bee 100644 --- a/source/exe/posix/platform_impl.cc +++ b/source/exe/posix/platform_impl.cc @@ -9,4 +9,6 @@ PlatformImpl::PlatformImpl() : thread_factory_(std::make_unique()), file_system_(std::make_unique()) {} +PlatformImpl::~PlatformImpl() = default; + } // namespace Envoy diff --git a/source/exe/win32/platform_impl.cc b/source/exe/win32/platform_impl.cc index 860a209a8e05..674ad0db0b1f 100644 --- a/source/exe/win32/platform_impl.cc +++ b/source/exe/win32/platform_impl.cc @@ -19,8 +19,6 @@ PlatformImpl::PlatformImpl() RELEASE_ASSERT(rc == 0, "WSAStartup failed with error"); } -~PlatformImpl() { ::WSACleanup(); } - -}; // namespace Envoy +PlatformImpl::~PlatformImpl() { ::WSACleanup(); } } // namespace Envoy