Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/config_dump skips the formatters field in SubstitutionFormatString #14821

Closed
rgs1 opened this issue Jan 25, 2021 · 4 comments
Closed

/config_dump skips the formatters field in SubstitutionFormatString #14821

rgs1 opened this issue Jan 25, 2021 · 4 comments
Labels
area/admin enhancement Feature requests. Not bugs or questions. investigate Potential bug that needs verification stale stalebot believes this issue/PR has not been touched recently

Comments

@rgs1
Copy link
Member

rgs1 commented Jan 25, 2021

We started using formatter extensions (#14512) and I noticed that the config dump endpoint skips the formatters field within the log_format message field [0], e.g.:

              "typed_config": {
               "@type": "type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog",
               "path": "/var/log/access.log",
               "log_format": {
                "text_format_source": {
                 "inline_string": "... stuff ...\n"
                }
               }

I suspect it might be either because:

a) TypedExtensionConfig fields are skipped
b) the actual message we are using within the TypedExtensionConfig message is empty

[0] https://github.com/envoyproxy/envoy/blob/main/api/envoy/config/core/v3/substitution_format_string.proto#L111

@rgs1 rgs1 added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Jan 25, 2021
@rgs1
Copy link
Member Author

rgs1 commented Jan 25, 2021

Not sure if this qualifies as bug or feature request actually.

@rgs1
Copy link
Member Author

rgs1 commented Jan 25, 2021

maybe related to #9669.

@yanavlasov yanavlasov added area/admin investigate Potential bug that needs verification and removed triage Issue requires triage labels Jan 26, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Feb 25, 2021
@github-actions
Copy link

github-actions bot commented Mar 4, 2021

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin enhancement Feature requests. Not bugs or questions. investigate Potential bug that needs verification stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

2 participants