Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated docs are no longer published in (circle) CI #13506

Closed
phlax opened this issue Oct 12, 2020 · 6 comments
Closed

Generated docs are no longer published in (circle) CI #13506

phlax opened this issue Oct 12, 2020 · 6 comments
Assignees
Labels
Milestone

Comments

@phlax
Copy link
Member

phlax commented Oct 12, 2020

description

since we moved to azure for docs generation in #13481 we lost the ability to click through to get the generated doc artefacts

i use this quite a lot and was in the process of adding a repokitteh command to make it easier to get the link to the artefact (#13326)

it would be great if we can publish the docs artefacts on azure too

@phlax phlax added bug triage Issue requires triage labels Oct 12, 2020
@mattklein123
Copy link
Member

Hmm yeah. It seems bad to lose this. @lizan or @phlax can we figure out how to bring this back somehow?

@mattklein123 mattklein123 added area/docs help wanted Needs help! and removed bug triage Issue requires triage labels Oct 12, 2020
@mattklein123 mattklein123 added this to the 1.17.0 milestone Oct 12, 2020
@phlax
Copy link
Member Author

phlax commented Oct 12, 2020

it seems we also have per pr publishing, eg

http://storage.googleapis.com/envoy-pr/13490/docs/start/start.html

ill close this as i can continue with what i was doing 8)

@phlax phlax closed this as completed Oct 12, 2020
@mattklein123
Copy link
Member

Oh nice. Can we update the docs and/or make this more obvious?

Maybe for docs can we have a CI step which is "Publish draft docs URL" and then just print the URL?

@phlax
Copy link
Member Author

phlax commented Oct 12, 2020

yep, and perhaps repokitteh can also help here

@lizan
Copy link
Member

lizan commented Oct 12, 2020

@phlax yeah I think use rk to publish them as detail url makes sense. (same for coverage report)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants