Skip to content

Commit 4809576

Browse files
committed
Compile options fix, if signals are disabled don't run the tests.
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
1 parent 3546d55 commit 4809576

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

test/extensions/filters/http/kill_request/crash_integration_test.cc

+4
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@ class CrashIntegrationTest : public Event::TestUsingSimulatedTime,
3333
// ASAN hijacks the signal handlers, so the process will die but not output
3434
// the particular messages we expect.
3535
#ifndef ASANITIZED
36+
// If we don't install any signal handlers (i.e. due to compile options), we
37+
// won't get the crash report.
38+
#ifdef ENVOY_HANDLE_SIGNALS
3639

3740
// Tests should run with all protocols.
3841
class CrashIntegrationTestAllProtocols : public CrashIntegrationTest {};
@@ -90,6 +93,7 @@ TEST_P(CrashIntegrationTestAllProtocols, ResponseCrashDumpsTheCorrespondingReque
9093
}
9194
#endif
9295
#endif
96+
#endif
9397

9498
} // namespace
9599
} // namespace KillRequest

0 commit comments

Comments
 (0)