[wasm] Fix raw handles, delay getContext call to be WebGPU compatible
#368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
changed the title
getContext call to be WebGPU comptiblegetContext call to be WebGPU compatible
|
ah the ci config didn't age well, have to fix this up |
Wumpf
force-pushed
the
fix-wasm-raw-handle
branch
from
50777e3 to
37307d9
Compare
|
done! |
|
Awesome! Thanks for the fixes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fixed various warnings & added a CI step to check the wasm target.
The reason
getContexthave to be delayed here is that this stateful: OncegetContextis called with one type of context (2d,webglorwebgpu), any future call with a different type will fail.-> Previously, it was not possible to use the canvas with a WebGL/WebGPU context since
minifbwould call.get_context("2d")during initialization.Tested this on https://github.com/Wumpf/minifb_wgpu_web_and_desktop (at Wumpf/minifb_wgpu_web_and_desktop@e39be06)