Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eframe: rfd file dialog causes app to freeze on MacOS. #977

Closed
cessen opened this issue Dec 20, 2021 · 4 comments
Closed

eframe: rfd file dialog causes app to freeze on MacOS. #977

cessen opened this issue Dec 20, 2021 · 4 comments
Labels
bug Something is broken

Comments

@cessen
Copy link

cessen commented Dec 20, 2021

With the latest version of eframe, attempting to open an rfd dialog will freeze the application.

This appears to be the same as this bug in winit:
rust-windowing/winit#2027

A fix was made, but was only merged recently. The first release with the fix is 0.26.0, which was also released recently. However, currently eframe (indirectly through egui-glium/egui-winit) is still using 0.25.0:

winit = "0.25"

(This is currently affecting a suite of software tools I'm writing that is pending release, so getting addressed soon would be very appreciated! Although, of course, I realize this is a volunteer open source project, so I don't mean to be pushy.)

@cessen cessen added the bug Something is broken label Dec 20, 2021
@emilk
Copy link
Owner

emilk commented Dec 20, 2021

Closed by #930

@emilk emilk closed this as completed Dec 20, 2021
@cessen
Copy link
Author

cessen commented Dec 20, 2021

Thanks so much!

@cessen
Copy link
Author

cessen commented Dec 22, 2021

Sorry to bother you again, but it looks like the full dependency chain hasn't been updated yet, so eframe still has the bug:

egui-winit = { version = "0.15.0", path = "../egui-winit", default-features = false }

I'm also not totally sure how specify a dependency on an updated eframe that hasn't been published to crates.io--the syntax in Cargo.toml for specifying a git repository as a dependency doesn't seem to allow sub-paths. (I'm not looking for help trouble-shooting that, btw, it's just to say that a patch release would be very appreciated if you have the time!)

@cessen
Copy link
Author

cessen commented Dec 22, 2021

Ah, so upon further investigation it looks like if I specify my eframe dependency as this github repo, Cargo automatically crawls the entire contents and will use this repo for all dependencies with matching crate names. Sorry for the noise! (Although a patch release would still be appreciated if you have the time.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Projects
None yet
Development

No branches or pull requests

2 participants