With X11 shift:both_capslock, pressing and releasing shift in a textbox acts as it was not released

[5225225]

Describe the bug
When I press shift inside any TextEdit that has text in it, and then move the cursor with the arrow keys or clicking, all text from the original position to the new one is selected.

To Reproduce
Steps to reproduce the behavior:

1. Be using X11 and have the shift:both_capslock option set (setxkbmap -option shift:both_capslock to set, setxkbmap -option to clear all options, run setxkbmap -query to see what options have been set already).
2. Type some text in a TextEdit. I used the egui_demo_app.
3. Press and release shift. Left or right shift, either works.
4. Move the text cursor. Any method works, I've tested the mouse, arrow keys, and home/end keys.

Expected behavior
Moving the cursor should not select text if shift is not actively being pressed

Desktop (please complete the following information):

• OS: Arch Linux (xorg-server version 1.20.13-2, i3-gaps wm version 4.20-1)

---

I've had a look, and it looks like

egui/egui-winit/src/lib.rs

Line 462 in b31ca7e

let pressed = input.state == winit::event::ElementState::Pressed;

is at fault here. When I have this option set, I never actually get this being set to false. If I press left shift, I get a pressed event, if I then press right shift, this event isn't triggered. When I release left shift, nothing happens, and when I release right shift, pressed = false is set.

If look at on_event in the same file, we do get ModifiersChanged events that look to be correct. Maybe we should be looking at that event instead?

[emilk]

Listening to ModifiersChanged instead sounds reasonable! Do you want to make a PR?