Skip to content

Commit d09fa63

Browse files
committed
Fix Ui::add_visible sometimes leaving the Ui in a disabled state
Closes #1436
1 parent 6091370 commit d09fa63

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ NOTE: [`epaint`](epaint/CHANGELOG.md), [`eframe`](eframe/CHANGELOG.md), [`egui_w
2323
* Fixed ComboBoxes always being rendered left-aligned ([#1304](https://github.com/emilk/egui/pull/1304)).
2424
* Fixed ui code that could lead to a deadlock ([#1380](https://github.com/emilk/egui/pull/1380)).
2525
* Text is darker and more readable in bright mode ([#1412](https://github.com/emilk/egui/pull/1412)).
26+
* Fixed `Ui::add_visible` sometimes leaving the `Ui` in a disabled state. ([#1436](https://github.com/emilk/egui/issues/1436)).
2627

2728
### Removed 🔥
2829
* Removed the `single_threaded/multi_threaded` flags - egui is now always thread-safe ([#1390](https://github.com/emilk/egui/pull/1390)).

egui/src/ui.rs

+5
Original file line numberDiff line numberDiff line change
@@ -1097,9 +1097,14 @@ impl Ui {
10971097
if self.is_visible() && !visible {
10981098
// temporary make us invisible:
10991099
let old_painter = self.painter.clone();
1100+
let old_enabled = self.enabled;
1101+
11001102
self.set_visible(false);
1103+
11011104
let response = self.add(widget);
1105+
11021106
self.painter = old_painter;
1107+
self.enabled = old_enabled;
11031108
response
11041109
} else {
11051110
self.add(widget)

0 commit comments

Comments
 (0)