Custom From header for InviteBridge causes strange behaviour.

[yallxe]

Hello,
I'm trying to use the InviteBridge function with custom From header (because I'm trying to call a remote UAS), and it doesn't work well. It didn't add automatically a tag to From header, but I decided to add it manually. It fixed the issue partially, but the ACK that is send after 200 OK had wrong From tag there, which confused me even more. Here is my code:

outFromHeader = sip.FromHeader{
	Address: sip.Uri{
		User: "foobar",
		Host: "foobar.com",
		Port: 5060,
	},
	Params: sip.NewParams().Add("tag", sip.GenerateTagN(16)),
}
outDialog, err := d.InviteBridge(ctx, destinationSipUri, &bridge, diago.InviteOptions{
	Username:    authUsername,
	Password:    authPassword,
	TransportID: "remote",
	Headers:     []sip.Header{
		sip.NewHeader("From", outFromHeader.Value()),
	},
)
...

[emiago]

Hi @yallxe . Current logic is that it checks do you have dialog added into bridge.
It could be not best design, but it takes that as originator.
Now when I see this, it could be also wrong design, and originator should be explicit.

Try adding your originator into bridge before dialing

[yallxe]

I modified my code a little bit:

outFromHeader = sip.FromHeader{
	Address: sip.Uri{
		User: "foobar",
		Host: "foobar.com",
		Port: 5060,
	},
	Params: sip.NewParams(),  // if this was nil, i was getting panic somewhere inside diago's code
}
outDialog, err := d.InviteBridge(ctx, destinationSipUri, &bridge, diago.InviteOptions{
	Username:    authUsername,
	Password:    authPassword,
	TransportID: "remote",
	Headers:     []sip.Header{
		&outFromHeader,
	},
)

And it works just fine. Absolutely no errors or bugs.

[emiago]

hi @yallxe . Ok I see. You want some custom From header. Sure it is find to pass,
but generally you want to have this from user same as originator (dialog with who you are bridging).
Normally this is what diago will update for you, but yeah if you need more custom from this is fine.

Yes, I think there are no checks in case nil, this is probably more on sipgo lib.